Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Stream URL #193

Merged
merged 4 commits into from
Mar 30, 2024
Merged

Support for Stream URL #193

merged 4 commits into from
Mar 30, 2024

Conversation

svrooij
Copy link
Owner

@svrooij svrooij commented Mar 30, 2024

Stream URL support and GroupID in devices

Description

The shortcut method now supports direct stream urls.

sonos.SetAVTransportURI('x-rincon-mp3radio://https://kexp.streamguys1.com/kexp160.aac');

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • Check you add tests for added code.

💔 Thank you!

svrooij added 2 commits March 30, 2024 16:48
when loaded from SonosManager

Fixed #182
@coveralls
Copy link

coveralls commented Mar 30, 2024

Pull Request Test Coverage Report for Build 8492131351

Details

  • 14 of 19 (73.68%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 78.63%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sonos-manager.ts 4 5 80.0%
src/sonos-device.ts 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
src/sonos-device.ts 2 66.03%
Totals Coverage Status
Change from base Build 8492089456: -0.1%
Covered Lines: 1698
Relevant Lines: 2117

💛 - Coveralls

@svrooij svrooij merged commit e26cf9a into beta Mar 30, 2024
10 checks passed
@svrooij svrooij deleted the feature/stream-url branch March 30, 2024 17:03
Copy link

🎉 This PR is included in version 2.6.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants